Skip to content

Conversation

@geoffrich
Copy link
Member

@geoffrich geoffrich commented Feb 9, 2022

The code blocks in the FAQ were either missing languages or had the incorrect language (the API used to parse the markdown requires sv for Svelte).

sveltejs/sites#297 should be merged and released first so that the correct styles are applied.

See sveltejs/kit#3794 (comment) for context

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@geoffrich geoffrich requested a review from benmccann February 9, 2022 17:08
@benmccann benmccann merged commit a4a1c3c into sveltejs:master Feb 9, 2022
@geoffrich geoffrich deleted the syntax-highlight branch February 9, 2022 17:12
himanshiLt pushed a commit to himanshiLt/svelte that referenced this pull request Mar 3, 2022
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Mar 14, 2022
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Apr 21, 2022
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Apr 21, 2022
nevilm-lt pushed a commit to nevilm-lt/svelte that referenced this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants